Delay S3 repo warning if default region absent #133848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today we emit a log message at startup if we fail to look up the default region for use by the S3 repository. However, this is only a potential issue if the default region is needed. If the user doesn't use `repository-s3` at all, or specifies the `region` for each S3 repository, then the absence of the default region is not an issue. With this commit we delay logging anything until we encounter a situation where we actually need the default region for something.
DaveCTurner
added
>bug
:Distributed Coordination/Snapshot/Restore
elasticsearchmachine
added
the
Team:Distributed Coordination
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
|
Hi @DaveCTurner, I've created a changelog YAML for you. |
ywangd
approved these changes
Sep 1, 2025
DaveCTurner
added
auto-merge-without-approval
|
I forgot to add the backport labels, now fixed, just calling that out in a comment here in case you have any concerns. IMO we definitely want this in the 8.19 branch which will live for a long time, 9.1 is less important since it will be replaced by 9.2 soon enough but also seems worthwhile. |
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Sep 1, 2025
Today we emit a log message at startup if we fail to look up the default region for use by the S3 repository. However, this is only a potential issue if the default region is needed. If the user doesn't use `repository-s3` at all, or specifies the `region` for each S3 repository, then the absence of the default region is not an issue. With this commit we delay logging anything until we encounter a situation where we actually need the default region for something.
💔 Backport failed
You can use sqren/backport to manually backport by running |
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Sep 1, 2025
Today we emit a log message at startup if we fail to look up the default region for use by the S3 repository. However, this is only a potential issue if the default region is needed. If the user doesn't use `repository-s3` at all, or specifies the `region` for each S3 repository, then the absence of the default region is not an issue. With this commit we delay logging anything until we encounter a situation where we actually need the default region for something. Backport of elastic#133848 to 8.19
|
Backport to 8.19 is #133918 |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 1, 2025
Today we emit a log message at startup if we fail to look up the default region for use by the S3 repository. However, this is only a potential issue if the default region is needed. If the user doesn't use `repository-s3` at all, or specifies the `region` for each S3 repository, then the absence of the default region is not an issue. With this commit we delay logging anything until we encounter a situation where we actually need the default region for something.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 3, 2025
Today we emit a log message at startup if we fail to look up the default region for use by the S3 repository. However, this is only a potential issue if the default region is needed. If the user doesn't use `repository-s3` at all, or specifies the `region` for each S3 repository, then the absence of the default region is not an issue. With this commit we delay logging anything until we encounter a situation where we actually need the default region for something. Backport of #133848 to 8.19
sarog
pushed a commit
to portsbuild/elasticsearch
that referenced
this pull request
Sep 11, 2025
Today we emit a log message at startup if we fail to look up the default region for use by the S3 repository. However, this is only a potential issue if the default region is needed. If the user doesn't use `repository-s3` at all, or specifies the `region` for each S3 repository, then the absence of the default region is not an issue. With this commit we delay logging anything until we encounter a situation where we actually need the default region for something. Backport of elastic#133848 to 8.19
sarog
pushed a commit
to portsbuild/elasticsearch
that referenced
this pull request
Sep 19, 2025
Today we emit a log message at startup if we fail to look up the default region for use by the S3 repository. However, this is only a potential issue if the default region is needed. If the user doesn't use `repository-s3` at all, or specifies the `region` for each S3 repository, then the absence of the default region is not an issue. With this commit we delay logging anything until we encounter a situation where we actually need the default region for something. Backport of elastic#133848 to 8.19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we emit a log message at startup if we fail to look up the default
region for use by the S3 repository. However, this is only a potential
issue if the default region is needed. If the user doesn't use
repository-s3at all, or specifies theregionfor each S3repository, then the absence of the default region is not an issue.
With this commit we delay logging anything until we encounter a
situation where we actually need the default region for something.